Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds the forestrie confirm message #13

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

robinbryce
Copy link
Collaborator

  • Adds MerkleLogConfirm &Adds MerkleLogConfirmMessage
  • Adds MerkleLogUnequivocal & MerkleLogUnequivocalMessage (currently empty, just claims the pb ordinals we know we will need)
  • Removes MerkleLogCommitMongoDB
  • Removes log version, log epoch and massif index. All of which are harmful to our strategy for managing the backing storage. See changing the massifheight for important context
  • Adds EventResponseJSONAPI, which largely duplicates EventResponse but importantly, supports decoding the format the customer will see from our apis. The duplication is unfortunate, but it means we can stop having ad-hoc soultions to this problem in all our go-lang based demo code. It also means the data can be reliably decoded with protojson. the generic json unmarshal fails to deal with 64 bit unsigned integers (and other numbers) correctly for example.

honourfish
honourfish previously approved these changes Feb 27, 2024
@robinbryce robinbryce force-pushed the dev/robin/8336-signed-merkle-roots-8-returnpath branch from f2638ba to 554a17d Compare February 28, 2024 07:04
* Adds MerkleLogConfirm &Adds MerkleLogConfirmMessage
* Adds MerkleLogUnequivocal & MerkleLogUnequivocalMessage (currently
  empty, just claims the pb ordinals we know we will need)
* Removes MerkleLogCommitMongoDB
* Removes log version, log epoch and massif index. All of which
  are harmful to our strategy for managing the backing storage.
  See
  https://github.com/datatrails/
   epic-8120-scalable-proof-mechanisms/
   blob/e38ca5e050356a47028b1d2b47bb6f02ff6c5c3c/mmr/
   forestrie-mmrblobs.md#changing-the-massifheight-for-a-log
  for important context
* Adds EventResponseJSONAPI, which largely duplicates EventResponse but
  importantly, supports decoding the format the *customer* will see from
  our apis. The duplication is unfortunate, but it means we can stop
  having ad-hoc soultions to this problem in all our go-lang based demo
  code. It also means the data can be reliably decoded with protojson.
  the generic json unmarshal fails to deal with 64 bit unsigned integers
  (and other numbers) correctly for example.

Put EventResponseJSONAPI in its own file

And add appropriate file comments for both eventresponse.proto and
eventresponsejsonapi.proto

AB#8336
@robinbryce robinbryce force-pushed the dev/robin/8336-signed-merkle-roots-8-returnpath branch from 554a17d to c3209cd Compare February 28, 2024 07:22
@robinbryce robinbryce merged commit c7d9a8e into main Feb 28, 2024
3 checks passed
@robinbryce robinbryce deleted the dev/robin/8336-signed-merkle-roots-8-returnpath branch February 28, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants